Repository navigation
chore: remove dead Devbox Cloud code - #3050
Merged
Merged
Conversation
Devbox Cloud is shut down. These code paths only ran when DEVBOX_REGION was set, which never happens outside Devbox Cloud. - envir: drop IsDevboxCloud, DevboxRegion and the now-unused SSHTTY - telemetry: drop InCloud/CloudRegion metadata and the shell_access property (always "local" outside cloud) - vercheck: drop the cloud early return and its test - services: delete status.go; the .devbox.cloud status watcher had no callers (fsnotify becomes an indirect dependency) - examples: drop .devbox.cloud from the django .gitignore Fixes #3047 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
 [Medium impact] The PR appears safe to merge.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3047.
Devbox Cloud is shut down. These code paths only ran when
DEVBOX_REGIONwas set, which never happens outside Devbox Cloud, so this is dead code.Changes
IsDevboxCloud(),DevboxRegion, andSSHTTY(only used by the cloud shell-access check)InCloud/CloudRegionmetadata (Sentry context) and the Segmentshell_accessproperty. Outside cloud it was always"local", so the property carried no information.skip_if_devbox_cloudtest caseinternal/services/status.goentirely, not just the cloud branch.ListenToChangesandupdateServiceStatusOnRemotehad no callers; they watched the mutagen-synced.devbox.clouddir.fsnotifymoves to an indirect dependency ingo.mod..devbox.cloudfromexamples/stacks/django/.gitignoreNot in this PR
vscode-extension/src/openinvscode.tsstill mentionsdevbox-vms; it's being removed separately in the change that moves VS Code install and update to GitHub releases.envir.IsInBrowser()(START_WEB_TERMINAL) looks like it was also for the cloud web terminal, but the issue doesn't cover it, so I left it alone.Testing
go build ./...,go test ./...,golangci-lint run(0 issues),gofumptgit grep -n "IsDevboxCloud\|DevboxRegion\|DEVBOX_REGION\|devbox-vms"matches onlyopeninvscode.ts🤖 Generated with Claude Code